Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(719): text cropping storybook #781

Merged
merged 9 commits into from
Apr 3, 2023
Merged

docs(719): text cropping storybook #781

merged 9 commits into from
Apr 3, 2023

Conversation

mutebg
Copy link
Contributor

@mutebg mutebg commented Mar 27, 2023 •
edited

#719

What

Text cropping stories update

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the docs Improvements or additions to documentation label Mar 27, 2023
@mutebg mutebg changed the title docs(XXXX-0000): closes 719 docs(719): text cropping storybook Mar 27, 2023
@mutebg mutebg linked an issue Mar 27, 2023 that may be closed by this pull request
Update text cropping component scenarios - Storybook #719
Closed
@pp-serviceaccount
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs-pr.s3-website-eu-west-1.amazonaws.com/719-text-cropping-scenarios
Storybook: http://ncu-newskit-docs-pr.s3-website-eu-west-1.amazonaws.com/719-text-cropping-scenarios/storybook

@mutebg mutebg added the ready for review Please assist in getting this reviewed label Mar 27, 2023
Vanals
Vanals previously approved these changes Mar 27, 2023
View reviewed changes
JohnTParsons
JohnTParsons previously approved these changes Mar 28, 2023
View reviewed changes
mstuartf
mstuartf reviewed Mar 28, 2023
View reviewed changes
.storybook/preview.js Outdated
@@ -126,20 +101,11 @@ export const parameters = {

export const decorators = [
// Add wrapper around stories to limit their size
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment needs to be removed.

@mutebg mutebg merged commit a6d7aeb into main Apr 3, 2023
@mutebg mutebg deleted the docs/719-text-cropping-scenarios branch April 3, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTParsons JohnTParsons JohnTParsons approved these changes

@Vanals Vanals Vanals approved these changes

@mstuartf mstuartf mstuartf approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update text cropping component scenarios - Storybook
5 participants
@mutebg @pp-serviceaccount @JohnTParsons @Vanals @mstuartf