Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(743): update tag component scenarios - storybook #789

Merged
merged 21 commits into from
Apr 4, 2023

Conversation

JohnTParsons
Copy link
Collaborator

closes #743

What

  1. Background - Tag component scenarios
  2. What did you do - matched designs
  3. What does the reviewers should expect - revamped storybook page

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@JohnTParsons JohnTParsons added the ready for design review Please assist in getting this reviewed label Mar 28, 2023
@github-actions github-actions bot added the docs Improvements or additions to documentation label Mar 28, 2023
@pp-serviceaccount
Copy link
Collaborator

@JohnTParsons JohnTParsons added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels Mar 31, 2023
src/tag/__tests__/tag.stories.tsx Outdated Show resolved Hide resolved
src/tag/__tests__/tag.stories.tsx Outdated Show resolved Hide resolved
src/tag/__tests__/tag.stories.tsx Outdated Show resolved Hide resolved
mstuartf
mstuartf previously approved these changes Mar 31, 2023
mstuartf
mstuartf previously approved these changes Apr 3, 2023
mutebg
mutebg previously approved these changes Apr 3, 2023
@JohnTParsons JohnTParsons dismissed stale reviews from mutebg and mstuartf via 90ec07d April 3, 2023 11:40
@JohnTParsons JohnTParsons merged commit d0617a2 into main Apr 4, 2023
@JohnTParsons JohnTParsons deleted the docs/743-tag-storybook branch April 4, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Tag component scenarios - Storybook
4 participants