Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(752): svg chrome issue #796

Merged
merged 38 commits into from
Apr 6, 2023
Merged

docs(752): svg chrome issue #796

merged 38 commits into from
Apr 6, 2023

Conversation

mutebg
Copy link
Contributor

@mutebg mutebg commented Mar 30, 2023

#752

What

  1. Background -SVGs with a filter does not render correctly in Chrome
  2. What did you do - removed all filters, usually, these are shadows which provide a bit more details to the graphics but we can go without them for now.
  3. What does the reviewers should expect - Probably is hard to code-review this PR since including lots of files. Use VS Code to review it

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the docs Improvements or additions to documentation label Mar 30, 2023
@pp-serviceaccount
Copy link
Collaborator

@mutebg mutebg changed the title Docs/752-svg-issue docs/752-svg-chrome-issue Mar 31, 2023
@mutebg mutebg added the ready for review Please assist in getting this reviewed label Mar 31, 2023
@mutebg mutebg marked this pull request as ready for review March 31, 2023 12:00
@mutebg mutebg changed the title docs/752-svg-chrome-issue docs(752): svg chrome issue Mar 31, 2023
@mutebg mutebg requested review from jps and JohnTParsons April 4, 2023 09:30
package.json Outdated Show resolved Hide resolved
jps
jps previously approved these changes Apr 4, 2023
JohnTParsons
JohnTParsons previously approved these changes Apr 5, 2023
@mutebg mutebg dismissed stale reviews from JohnTParsons and jps via daed076 April 5, 2023 09:35
@mutebg mutebg requested review from JohnTParsons and jps April 5, 2023 09:37
JohnTParsons
JohnTParsons previously approved these changes Apr 5, 2023
jps
jps previously approved these changes Apr 5, 2023
@mutebg mutebg dismissed stale reviews from jps and JohnTParsons via 1a2eb34 April 5, 2023 12:52
JohnTParsons
JohnTParsons previously approved these changes Apr 5, 2023
@mutebg mutebg merged commit 8b9535b into main Apr 6, 2023
@mutebg mutebg deleted the docs/752-svg-issue branch April 6, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Bug) - svg images on docs sites are not displaying correctly in Chrome
6 participants