Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(734): move header above sidebar in html #801

Merged
merged 3 commits into from
Apr 6, 2023
Merged

Conversation

mstuartf
Copy link
Contributor

@mstuartf mstuartf commented Apr 3, 2023

#734

What

  1. Background - why this is needed
  2. What did you do
  3. What does the reviewers should expect

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@mstuartf mstuartf added the draft This is a draft PR and not intended for formal review yet label Apr 3, 2023
@github-actions github-actions bot added the docs Improvements or additions to documentation label Apr 3, 2023
@pp-serviceaccount
Copy link
Collaborator

@mutebg mutebg linked an issue Apr 4, 2023 that may be closed by this pull request
@mutebg mutebg added ready for review Please assist in getting this reviewed and removed draft This is a draft PR and not intended for formal review yet labels Apr 5, 2023
@mstuartf mstuartf merged commit 4cb851a into main Apr 6, 2023
@mstuartf mstuartf deleted the docs/734-focus-order branch April 6, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility fixes for docs site: Focus order on secondary pages
4 participants