Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(809): Button alignment mismatching on Custom restore focus - Modal scenario #813

Merged
merged 2 commits into from
Apr 7, 2023

Conversation

jannuk59
Copy link
Contributor

@jannuk59 jannuk59 commented Apr 6, 2023

#809

What

Button alignment mismatching on Custom restore focus scenario - Modal Component Storybook Scenarios

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the fix This change fixes a bug label Apr 6, 2023
@jannuk59 jannuk59 added the ready for design review Please assist in getting this reviewed label Apr 6, 2023
@jannuk59 jannuk59 added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed labels Apr 6, 2023
@jannuk59 jannuk59 marked this pull request as ready for review April 6, 2023 13:12
@jannuk59 jannuk59 merged commit a49552d into main Apr 7, 2023
@jannuk59 jannuk59 deleted the fix/809-button-allignment-modal-scenario branch April 7, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix This change fixes a bug ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants