Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(751): add optimisation to with-own-theme #838

Merged
merged 2 commits into from
Apr 19, 2023
Merged

feat(751): add optimisation to with-own-theme #838

merged 2 commits into from
Apr 19, 2023

Conversation

JohnTParsons
Copy link
Collaborator

@JohnTParsons JohnTParsons commented Apr 18, 2023 •
edited

closes #751

What

Add optimisation to with-own-theme to speed up re-rendering of components (including Drawer).

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@JohnTParsons JohnTParsons added the ready for review Please assist in getting this reviewed label Apr 18, 2023
@github-actions github-actions bot added the feature This change contains a new feature label Apr 18, 2023
@pp-serviceaccount
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs-pr.s3-website-eu-west-1.amazonaws.com/751-with-own-theme
Storybook: http://ncu-newskit-docs-pr.s3-website-eu-west-1.amazonaws.com/751-with-own-theme/storybook

@mutebg mutebg merged commit 3d8b570 into main Apr 19, 2023
@mutebg mutebg deleted the feat/751-with-own-theme branch April 19, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jps jps jps approved these changes

@mutebg mutebg mutebg approved these changes

@jannuk59 jannuk59 jannuk59 approved these changes

Assignees
No one assigned
Labels
feature This change contains a new feature ready for review Please assist in getting this reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add optimisation to with-own-theme function
5 participants
@JohnTParsons @pp-serviceaccount @jps @mutebg @jannuk59