Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(732): fix inline drawer behaviour #839

Merged
merged 12 commits into from
Apr 20, 2023
Merged

fix(732): fix inline drawer behaviour #839

merged 12 commits into from
Apr 20, 2023

Conversation

mstuartf
Copy link
Contributor

@mstuartf mstuartf commented Apr 18, 2023

#732

What

  1. Background - why this is needed
  • Inline drawer shifting sibling content in right and bottom placements
  1. What did you do
  • Disable the FocuLock and MoveFocusInside components while a transition in in progress. Focussing on an element that is not yet in view causes the browser to attempt to scroll, which is what causes the elements to shift. Store transition state in a local variable and use the CSSTransition onEntered and onExited handlers to update its value.
  • Add tests.
  1. What does the reviewers should expect
  • Inline drawer should no longer shift sibling content

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the fix This change fixes a bug label Apr 18, 2023
@pp-serviceaccount
Copy link
Collaborator

@mstuartf mstuartf changed the title fix(732): use correct focus lock component for drawer fix(732): fix inline drawer behaviour Apr 20, 2023
@mstuartf mstuartf added the ready for review Please assist in getting this reviewed label Apr 20, 2023
@mstuartf mstuartf merged commit bd456c1 into main Apr 20, 2023
33 of 37 checks passed
@mstuartf mstuartf deleted the fix/732-inline-drawer branch April 20, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix This change fixes a bug ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants