Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(798): move build icons into install deps #863

Merged
merged 4 commits into from
May 3, 2023
Merged

Conversation

mstuartf
Copy link
Contributor

@mstuartf mstuartf commented May 2, 2023

closes #798

What

  1. Background - why this is needed
  • Speed up pipeline
  1. What did you do
  • Move build icons into install deps pipeline stage
  1. What does the reviewers should expect
  • Pipeline should run successfully

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@pp-serviceaccount
Copy link
Collaborator

@mstuartf mstuartf added the ready for review Please assist in getting this reviewed label May 2, 2023
@mstuartf mstuartf merged commit 46c9877 into main May 3, 2023
32 of 36 checks passed
@mstuartf mstuartf deleted the ci/798-consolidate-steps branch May 3, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipeline improvement - Build Icons as part of install_deps
4 participants