Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(919): update node version in circleci #920

Merged
merged 8 commits into from
Sep 26, 2023
Merged

Conversation

mutebg
Copy link
Contributor

@mutebg mutebg commented Sep 25, 2023

closes #919

What

  1. Background - missing google sheets file and old version of nodejs are breaking our pipeline
  2. What did you do - updated nodejs on circleci and removed google sheets API, replacing it with static information
  3. What does the reviewers should expect - everything should look exactly the same

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@mutebg mutebg requested a review from a team as a code owner September 25, 2023 07:53
@pp-serviceaccount
Copy link
Collaborator

@mutebg mutebg added the docs Improvements or additions to documentation label Sep 25, 2023
JohnTParsons
JohnTParsons previously approved these changes Sep 25, 2023
lhaggar
lhaggar previously approved these changes Sep 25, 2023
@mutebg mutebg merged commit c7bc065 into main Sep 26, 2023
32 of 36 checks passed
@mutebg mutebg deleted the ci/919-update-node-circleci branch September 26, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update nodejs image in Circle CI
5 participants