Theia devel 1.40 mixed #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Docker does not support setting build variables to different values for different platforms. - Therefore we move the Theia version specification from `build.sh` into `Dockerfile` - Bash shell and a BASH_ENV script are used to automagically set the required env vars to the intended value for each platform - A `theia-exec` bash script is used to launch Theia in the diagnostic entrypoints. - Documentation for Updating Theia is updated accordingly.
Closed
MarkFitzpatrickNN
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having reluctantly concluded that Theia 1.40.0 is incompatible with the
linux/arm/v7platform (see #13) this presented a conundrum:linux/arm/v7, required to run on rPI 32bit Raspbian?(1) is not an option. I am reluctant to accept (2) right now, as while there is now a 64bit version of Raspbian able to run on rPi 4, it is still relatively new and seems a shame to drop support when Dockside still works.
And it is not inconceivable that this issue will arise again, with a new version of Theia working on some supported platforms but not yet on others.
I have therefore opted to modify the build process to support different Theia versions for different platforms. Docker does not support setting build variables to different values for different platforms. This therefore entailed moving the Theia version specification from
build.shintoDockerfile, and a variety of other changes toDockerfileto facilitate the required env vars to be set to the intended value for each platform.This branch contains two commits: