Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(CPNT-2249): PHPCS config #2

Merged
merged 17 commits into from
Jan 15, 2024
Merged

feat(CPNT-2249): PHPCS config #2

merged 17 commits into from
Jan 15, 2024

Conversation

mohanrajpac
Copy link
Contributor

https://nidigitalsolutions.jira.com/browse/CPNT-2249

  • Adds VIP PHPCS ruleset as composer dependency

@mohanrajpac mohanrajpac mentioned this pull request Dec 27, 2023
Closed
@mohanrajpac mohanrajpac requested a review from a team January 2, 2024 12:09
edwil-jonas
edwil-jonas previously approved these changes Jan 4, 2024
View reviewed changes
Copy link

@edwil-jonas edwil-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @mohanrajpac 👍🏻

shadi-sharaf-nuk
shadi-sharaf-nuk reviewed Jan 8, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@jonnynews
Copy link
Contributor

We should considering adding a dependabot.yml and setup dependabot. Something to check for composer updates. Example

version: 2
updates:
  - package-ecosystem: "composer" # See documentation for possible values
    directory: "/" # Location of package manifests
    schedule:
      interval: "weekly"

File should be created in .github/dependabot.yml and enabled

jonnynews
jonnynews requested changes Jan 9, 2024
View reviewed changes
NewsUK/ruleset.xml Show resolved Hide resolved
NewsUK/ruleset.xml Show resolved Hide resolved
NewsUK/ruleset.xml Show resolved Hide resolved
NewsUK/ruleset.xml Show resolved Hide resolved
edwil-jonas
edwil-jonas approved these changes Jan 15, 2024
View reviewed changes
Copy link

@edwil-jonas edwil-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@mohanrajpac mohanrajpac merged commit 121d4f2 into main Jan 15, 2024
1 check passed
@mohanrajpac mohanrajpac deleted the feat/CPNT-2249-phpcs-config branch January 15, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwil-jonas edwil-jonas edwil-jonas approved these changes

@shadi-sharaf-nuk shadi-sharaf-nuk shadi-sharaf-nuk approved these changes

@jonnynews jonnynews jonnynews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mohanrajpac @jonnynews @edwil-jonas @shadi-sharaf-nuk