Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing bitcode. #1

Merged
merged 7 commits into from
Jul 14, 2023
Merged

Implementing bitcode. #1

merged 7 commits into from
Jul 14, 2023

Conversation

35C4n0r
Copy link
Collaborator

@35C4n0r 35C4n0r commented Jun 28, 2023

This PR Implements the pure python variant of intbitset.

Class:

  • intbitset

Methods:

  • add
  • clear
  • copy
  • difference
  • difference_update
  • discard
  • extract_finite_list
  • fastdump
  • fastload
  • get_allocated
  • get_size
  • get_wordbitsize
  • get_wordbytesize
  • intersection
  • intersection_update
  • isdisjoint
  • issubset
  • issuprset
  • is_infinite
  • pop
  • remove
  • strbits
  • symetric_difference
  • symetric_difference_update
  • tolist
  • union
  • union_update
  • update
  • update_with_signs

- added intbitset class and it's methods.

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>
- added the remaining methods for intbitset class.

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>
Copy link
Contributor

@JonoYang JonoYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@35C4n0r Just pointing out a few small things

src/bitcode/intbitset.py Outdated Show resolved Hide resolved
src/bitcode/intbitset.py Outdated Show resolved Hide resolved
src/bitcode/intbitset.py Outdated Show resolved Hide resolved
35C4n0r and others added 3 commits July 1, 2023 13:08
Refactoring Typos.

Co-authored-by: Jono Yang <JonoYang@users.noreply.github.com>
Refactoring Typos.

Co-authored-by: Jono Yang <JonoYang@users.noreply.github.com>
- added new tests for the intbitset class.
- updated README.rst.
- Tried adding workflows.

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>
@35C4n0r 35C4n0r marked this pull request as ready for review July 1, 2023 14:08
@35C4n0r 35C4n0r requested a review from JonoYang July 1, 2023 14:10
Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>
@35C4n0r
Copy link
Collaborator Author

35C4n0r commented Jul 1, 2023

@JonoYang, thanks for the review. I have added the changes, a few tests, and I also tried adding the github workflow to run the test.

@JonoYang
Copy link
Contributor

JonoYang commented Jul 3, 2023

@35C4n0r I've enabled Azure Pipelines for CI testing on the ahocode and bitcode repos

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>
@35C4n0r
Copy link
Collaborator Author

35C4n0r commented Jul 9, 2023

@JonoYang I have removed the github workflows, and i don't thin i need to make any changes in the azure-pipelines.yml
The PR is ready for review.

@35C4n0r
Copy link
Collaborator Author

35C4n0r commented Jul 9, 2023

@JonoYang also please make a repo for lxml so that I can start working on it.

@JonoYang
Copy link
Contributor

@35C4n0r I've created the xml fallback library repo at https://github.com/nexb/sanexml

@JonoYang
Copy link
Contributor

@35C4n0r Is there anything else you need to add to this PR, otherwise I will merge it.

@35C4n0r
Copy link
Collaborator Author

35C4n0r commented Jul 14, 2023

@JonoYang, I don't have anything more to add to PR.

@JonoYang
Copy link
Contributor

@35C4n0r I will merge the PR. Thanks for the contributions!

@JonoYang JonoYang merged commit d980d98 into nexB:main Jul 14, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pure python fallback dependancy for intbitset.
2 participants