-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cli tests #37
Comments
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@MaJuRG Please let me know what you think about my approach in this initial commit. I’ve added three
To support the
I’ve left my comments intact to help explain what I’ve done and pose open questions. All 130 tests pass, but the return in
|
* Removed and replaced ScanCode-based functions and tests. Signed-off-by: John M. Horan <johnmhoran@gmail.com>
@MaJuRG Is this closer to what you have in mind? I'm not sure my approach on this line is optimal -- I use a list comprehension but don't really want a list, so I need to grab the item at index 0, which seems a bit convoluted. I have an idea for a few more tests but welcome your suggestions -- including how we might test for the post-refactoring issues you've run into (you mention them in issue #38). |
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
#44 handles the start of this. Closing. |
* Replace all references to `tmp` with `venv` Signed-off-by: Jono Yang <jyang@nexb.com>
Use the scancode
cli.py
tests as a model. We mainly want to verify correct cli output in certain scenarios.The text was updated successfully, but these errors were encountered: