Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Similarity Matching by Fingerprint Comparison. #128

Merged
merged 10 commits into from
Aug 28, 2019
Merged

Similarity Matching by Fingerprint Comparison. #128

merged 10 commits into from
Aug 28, 2019

Conversation

arnav-mandal1234
Copy link
Collaborator

@arnav-mandal1234 arnav-mandal1234 commented Aug 9, 2019

  • Implementation of distance finding algorithm between the files and process them further.
  • Integration of fingerprint field in the JSON file to compare the deltas and provide them with appropriate scores.
  • Modification of old unit tests
  • Addition of new unit tests

Copy link
Contributor

@steven-esser steven-esser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial comments left.

This is a good start. You will of course have to write tests and fix the current failures, but this is good progress.

src/deltacode/__init__.py Outdated Show resolved Hide resolved
src/deltacode/__init__.py Outdated Show resolved Hide resolved
src/deltacode/__init__.py Outdated Show resolved Hide resolved
Copy link
Contributor

@steven-esser steven-esser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on the addressing most of the previous changes. See my comments relating to the similarity() function.

Once you address those and add robust integration tests, we can review further.

src/deltacode/__init__.py Outdated Show resolved Hide resolved
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
Copy link
Contributor

@steven-esser steven-esser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments. We probably do not need to copy over the whole file from scancode. We only really need the function that checks two JSON files, correct?

Also, you have not added any tests yet so there is not much else for me to review.

src/deltacode/__init__.py Outdated Show resolved Hide resolved
src/deltacode/utils.py Outdated Show resolved Hide resolved
src/deltacode/cli_test_utils.py Outdated Show resolved Hide resolved
src/deltacode/cli_test_utils.py Outdated Show resolved Hide resolved
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
Copy link
Contributor

@steven-esser steven-esser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor changes at this time. If we are going to keep the test_utils in their own file, can we just put it under the tests/ directory?

tests/test_deltacode.py Outdated Show resolved Hide resolved
tests/test_deltacode.py Outdated Show resolved Hide resolved
tests/test_deltacode.py Outdated Show resolved Hide resolved
src/deltacode/cli_test_utils.py Outdated Show resolved Hide resolved
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
Copy link
Contributor

@JonoYang JonoYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response. It looks good, please look at my changes so the tests work properly

tests/test_deltacode.py Outdated Show resolved Hide resolved
tests/test_deltacode.py Outdated Show resolved Hide resolved
tests/test_deltacode.py Outdated Show resolved Hide resolved
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
@steven-esser steven-esser merged commit 6778882 into nexB:develop Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants