-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Similarity Matching by Fingerprint Comparison. #128
Similarity Matching by Fingerprint Comparison. #128
Conversation
arnav-mandal1234
commented
Aug 9, 2019
•
edited
Loading
edited
- Implementation of distance finding algorithm between the files and process them further.
- Integration of fingerprint field in the JSON file to compare the deltas and provide them with appropriate scores.
- Modification of old unit tests
- Addition of new unit tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial comments left.
This is a good start. You will of course have to write tests and fix the current failures, but this is good progress.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on the addressing most of the previous changes. See my comments relating to the similarity()
function.
Once you address those and add robust integration tests, we can review further.
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments. We probably do not need to copy over the whole file from scancode. We only really need the function that checks two JSON files, correct?
Also, you have not added any tests yet so there is not much else for me to review.
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor changes at this time. If we are going to keep the test_utils in their own file, can we just put it under the tests/
directory?
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late response. It looks good, please look at my changes so the tests work properly
Signed-off-by: arnav-mandal1234 <arnav.mandal1234@gmail.com>