Add docker file #178
Merged
Add docker file #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pratik Dey <pratikrocks.dey11@gmail.com>
Closed
steven-esser
suggested changes
Aug 7, 2021
|
Okay then i am adding in the RTD related Pr |
pombredanne
reviewed
Aug 16, 2021
docker-compose.yml
Outdated
| @@ -0,0 +1,28 @@ | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
| # | |||
| # http://nexb.com and https://github.com/nexB/scancode.io | |||
There was a problem hiding this comment.
I reckon you copied this from ScanCode.io... but there is no need to carry the scancode.io references
There was a problem hiding this comment.
This also should be changed in Dockerfile not just here in docker-compose.yml. There are other references to scancode.io too in the comments of both files that should be adapted.
It would be nice to have those changes soon and merged, as I would like to update my local installation and avoid creating my own Dockerfile locally.
Thanks a lot.
There was a problem hiding this comment.
@pombredanne , @ddmesh I changed those licenses Thanks :)
Signed-off-by: Pratik Dey <pratikrocks.dey11@gmail.com>
ddmesh
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
DockerFiledocker-compose.ymlSigned-off-by: Pratik Dey pratikrocks.dey11@gmail.com