Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump PSL and help with Debian packaging #14

Merged
merged 8 commits into from Feb 6, 2020
Merged

Bump PSL and help with Debian packaging #14

merged 8 commits into from Feb 6, 2020

Conversation

pombredanne
Copy link
Member

This is pretty small: the key changes are some fixes in packaging and a new PSL data list.
@kitterma FYI
@KnitCode you approval is welcomed!

hiratara and others added 7 commits December 22, 2019 16:27
test: disable idfa when using UTF-8
I've just packaged publicsuffix2 for Debian (so we can get rid of publicsuffix).  We like to run the package tests are part of our QA process, so it would be nice if they were included in the sdist.
Update MANIFEST.in so tests are in the sdist

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Copy link
Member Author

@hiratara this also includes your latest pushes 🙇‍♂️

@pombredanne
Copy link
Member Author

@dvzrv this would be the first release that I would start tagging as release-2.release-2.20200127 as per #12

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Copy link
Contributor

@KnitCode KnitCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks unicode... some of these public suffixes are amazingly complicated.
hopefully the documentation is clear that folks need to use a flag to separate unicode for punyencoded cases. now at least they have the tests. :)

@pombredanne
Copy link
Member Author

@KnitCode thank you. BTW do you write write access to this repo? You deserve it ++

@pombredanne pombredanne merged commit 63ce554 into master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants