-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump PSL and help with Debian packaging #14
Conversation
test: disable idfa when using UTF-8
I've just packaged publicsuffix2 for Debian (so we can get rid of publicsuffix). We like to run the package tests are part of our QA process, so it would be nice if they were included in the sdist.
Update MANIFEST.in so tests are in the sdist Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@hiratara this also includes your latest pushes 🙇♂️ |
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks unicode... some of these public suffixes are amazingly complicated.
hopefully the documentation is clear that folks need to use a flag to separate unicode for punyencoded cases. now at least they have the tests. :)
@KnitCode thank you. BTW do you write write access to this repo? You deserve it ++ |
This is pretty small: the key changes are some fixes in packaging and a new PSL data list.
@kitterma FYI
@KnitCode you approval is welcomed!