Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include license rule notes in data returned with a license match #1377

Open
Tracked by #1825
pombredanne opened this issue Feb 16, 2019 · 10 comments
Open
Tracked by #1825

Include license rule notes in data returned with a license match #1377

pombredanne opened this issue Feb 16, 2019 · 10 comments

Comments

@pombredanne
Copy link
Member

There is valuable information in these notes and they provide context for some less common rules and why these would have been detected.

@suryanshsrivastava
Copy link

suryanshsrivastava commented Feb 28, 2019

I am new to opensource and would like to work on this as my first issue to get acquainted to this repository and opensource in general, can you give me some initial directions as to how I can fix this issue?

@pombredanne
Copy link
Member Author

@suryanshsrivastava see how license-related data are returned in scancode/api.py
Otherwise license detection is in licensedcode/ and the data structure we use are in models and match

@pombredanne
Copy link
Member Author

What we need would be to include the Rules "notes" attributes in the returned data.

@YashJipkate
Copy link

Hi @pombredanne, I would like to work on this issue. Is this issue available? If yes, then could I be assigned to it?

@pombredanne
Copy link
Member Author

@YashJipkate by all please go for it!
The place to look into is going to be likely in src/scancode/cli.py

@pombredanne
Copy link
Member Author

And for the record this is now in the PR #1787

@dakshaladia
Copy link

I wish to contribute to this issue. Is it still available?

@n1khilmane
Copy link

hey! @pombredanne i can see the PR #1787 you mentioned above is closed, there were certain tests left i suppose , is it fine to contribute further for this issue?

@pombredanne
Copy link
Member Author

@n1khilmane sure thing! 👍

n1khilmane added a commit to n1khilmane/scancode-toolkit that referenced this issue Apr 23, 2020
@D-lang14
Copy link

D-lang14 commented Dec 8, 2020

Hey! @pombredanne sir, I am new to open source can you assign the issue if I can solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants