Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No dependency results when scanning celery-5.2.7.tar.gz #3083

Closed
JonoYang opened this issue Sep 1, 2022 · 1 comment
Closed

No dependency results when scanning celery-5.2.7.tar.gz #3083

JonoYang opened this issue Sep 1, 2022 · 1 comment

Comments

@JonoYang
Copy link
Contributor

JonoYang commented Sep 1, 2022

Originally reported at nexB/scancode.io#516

I've downloaded, extracted, and run a package scan on https://files.pythonhosted.org/packages/ce/21/41a0028f6d610987c0839250357c1a00f351790b8a448c2eb323caa719ac/celery-5.2.7.tar.gz but no dependency results show up in the top-level dependencies field.

I think this is due to the pypi package parser getting results from the celery-5.2.7/PKG-INFO file at the root of the codebase, but it cannot find any of the dependency versions and other info because the PKG-INFO file is not in an .egg-info directory. When running the package scanning debug flags, I see that we get the dependencies when we scan celery-5.2.7/celery.egg-info/PKG-INFO.

JonoYang added a commit that referenced this issue Sep 3, 2022
    * Update test expectations

Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang added a commit that referenced this issue Sep 3, 2022
    * Update test expectations

Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang added a commit that referenced this issue Sep 3, 2022
    * Add test for checking that the .egg-info PKG-INFO is the only Package source reported
    * Update test expectations

Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang added a commit that referenced this issue Sep 3, 2022
    * Add test for checking that the .egg-info PKG-INFO is the only Package source reported
    * Update test expectations

Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang added a commit that referenced this issue Sep 6, 2022
    * Add test for checking that the .egg-info PKG-INFO is the only Package source reported
    * Update test expectations

Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang added a commit that referenced this issue Sep 6, 2022
    * Ensure extracted_requirement contains dependency name
    * Update test expectations

Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang added a commit that referenced this issue Sep 6, 2022
    * Ensure extracted_requirement contains dependency name
    * Update test expectations

Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang added a commit that referenced this issue Sep 6, 2022
Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang added a commit that referenced this issue Sep 6, 2022
Prefer using PKG-INFO from .egg-info in assemble #3083
@JonoYang
Copy link
Contributor Author

JonoYang commented Sep 6, 2022

Fix merged in #3091

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant