Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inaccurate copyright detection #358

Closed
pombredanne opened this issue Nov 7, 2016 · 1 comment
Closed

Inaccurate copyright detection #358

pombredanne opened this issue Nov 7, 2016 · 1 comment
Labels
bug copyright scan easy

Comments

@pombredanne
Copy link
Member

Somehow the following string found in a binary is detected as a copyright:
2005charchar? 7 DDLSQL Server 2005smalldatetimedatetimeLDDDDDD7
It should not
pombredanne added a commit that referenced this issue Nov 8, 2016
@pombredanne
#358 Fixed with a proper pattern for YR year ranges POS
c7783ce 
 * the YR tag pattern was missing a trailing $ and therefore some
   strings starting with a year such as 2005foobar were detected as
   a year by mistake.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne added a commit that referenced this issue Nov 15, 2016
@pombredanne
#358 Fixed with a proper pattern for YR year ranges POS
6383d62 
 * the YR tag pattern was missing a trailing $ and therefore some
   strings starting with a year such as 2005foobar were detected as
   a year by mistake.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne added a commit that referenced this issue Feb 20, 2017
@pombredanne
#358 Fixed with a proper pattern for YR year ranges POS
f89dda6 
 * the YR tag pattern was missing a trailing $ and therefore some
   strings starting with a year such as 2005foobar were detected as
   a year by mistake.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne added a commit that referenced this issue Feb 21, 2017
@pombredanne
#358 Rework proper pattern for YR year ranges POS
0094182 
 * the YR tag pattern was missing some clarity and is now clearer
 * add additional minor refinements to some copyright mishaps
 * update tests
 * improve tests for windows binaries content type detection
  
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne added a commit that referenced this issue Feb 21, 2017
@pombredanne
Merge pull request #509 from nexB/358-copyright-years
f1c609a 
#358 Rework proper pattern for YR year ranges POS
@pombredanne
Copy link
Member Author

Fixed in develop

pombredanne added a commit that referenced this issue Jun 16, 2017
@pombredanne
Fix incorrect copyright detection #379 and #84
641378f 
 * also add test for #358

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug copyright scan easy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pombredanne