Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule to detect agpl-3-0-plus_or_commercial actually triggers on AGPL-3.0-plus without commercial remarks #3740

Open
zesoup opened this issue Apr 15, 2024 · 1 comment
Labels

Comments

@zesoup
Copy link

zesoup commented Apr 15, 2024

Description

The current rule agpl-3.0-plus_or_commercial-license_4.RUL classifies AGPL short descriptions as (AGPL-plus or commercial).

However, while the usecase may often be linked to commercial licenses the exact snippet within the rule does not mention commercial availability at all hence i suggest changing this to omit the "or commercial" part of things.

@zesoup zesoup added the bug label Apr 15, 2024
@pombredanne
Copy link
Member

@zesoup good catch! this is a mistake and a bug. This rule https://github.com/nexB/scancode-toolkit/blob/develop/src/licensedcode/data/rules/agpl-3.0-plus_or_commercial-license_4.RULE should be strictly about AGPL and has nothing about commercial!

404-geek added a commit to 404-geek/scancode-toolkit that referenced this issue Apr 17, 2024
Signed-off-by: 404-geek <pranayd61@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants