Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect license GPL is detected #92

Closed
rakeshbalusa opened this issue Oct 19, 2015 · 4 comments
Closed

incorrect license GPL is detected #92

rakeshbalusa opened this issue Oct 19, 2015 · 4 comments
Assignees
@JonoYang
Labels
license scan
Milestone
v2.0

Comments

@rakeshbalusa
Copy link

OS: windows 7 64 bit
I've updated my scancode to the latest version available.
file : README.txt

scancode output :

Path                                    What    Start Line  End Line        Info
C:/doc/temporary/issue_files/README License      28 28      GPL 2.0

In the README file attached there is license text which says BSD Unix, and not under the GNU General Public License (GPL). in the line 28. This means the correct license is BSD but no GPL
@rakeshbalusa rakeshbalusa changed the title wrong license is detected incorrect license GPL is detected Jan 28, 2016
@pombredanne pombredanne modified the milestone: v2.0 Aug 5, 2016
@pombredanne pombredanne assigned JonoYang and unassigned balusarakesh Oct 21, 2016
JonoYang added a commit that referenced this issue Oct 24, 2016
@JonoYang
#92: Add 'not-a-license' rule to remove GPL false positive
1c9b3ab
pombredanne added a commit that referenced this issue Oct 24, 2016
@pombredanne
Merge pull request #344 from nexB/92-incorrect-license-gpl-detected
49f8f15 
#92: Add 'not-a-license' rule to remove GPL false positive
@pombredanne
Copy link
Member

@JonoYang I am reopening as this is missing a test

@pombredanne pombredanne reopened this Oct 24, 2016
JonoYang added a commit that referenced this issue Oct 25, 2016
@JonoYang
#92 Add flex readme as a test for flex license
b7e25d8
pombredanne pushed a commit that referenced this issue Oct 26, 2016
@JonoYang @pombredanne
#92 Add flex readme as a test for flex license
34fd7ba
pombredanne added a commit that referenced this issue Oct 26, 2016
@pombredanne
#92 Convert negative rule to regular for flex detection
35268e4 
 * This rule text mentions clearly the flex licensing (and states this
   is not GPL). Therefore the rule was renamed accordingly and a
   detected license flex-2.5 added
  
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne added a commit that referenced this issue Oct 26, 2016
@pombredanne
#92 Simplify netbsd license
e4fb341 
 * remove "This code is derived from software contributed to" which is
   not really part of the license itself. Also remove this from
   all other licenses and rules.
 * remove SDPX text which is introducing several ambiguities and does
   not contribute to improved detection accuracy
 * remove duplicated rules

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne added a commit that referenced this issue Oct 26, 2016
@pombredanne
#92 Simplify flex-2.5 text
0a55aae 
 * remove copyright statement
 * add extra rules for detection

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Copy link
Member

@JonoYang ready for your review. Here is what I did:

  1. the negative rule you added was really a positive rule: I renamed it
  2. there were several ambiguities introduced by flex-2.5 and other rules that did not contribute to accurate license detection. I made quite a few updates accordingly
  3. finally, I edited the branch history to rebase cleanly on develop rather than merging and forced pushed the branch. This is preferred for feature branches to avoid polluting the history with too many un-needed merge commits. (forced pushing is never nor allowed on the master and develop branches FWIW)

@pombredanne
Copy link
Member

See #349

pombredanne added a commit that referenced this issue Oct 26, 2016
@pombredanne
#92 Correct failing integration test
40e7de8 
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne added a commit that referenced this issue Oct 26, 2016
@pombredanne
Merge pull request #349 from nexB/92-incorrect-license-gpl-detected
00ab5b8 
#92 incorrect license gpl detected
@pombredanne
Copy link
Member

All set.

@pombredanne pombredanne mentioned this issue Jan 27, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JonoYang JonoYang

Labels
license scan
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
4 participants
@pombredanne @JonoYang @rakeshbalusa @balusarakesh