Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure license expressions are present in CSV output #1239

Merged
merged 3 commits into from Oct 31, 2018

Conversation

pombredanne
Copy link
Member

This is a fix for #1238

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@codecov
Copy link

codecov bot commented Oct 31, 2018

Codecov Report

Merging #1239 into develop will decrease coverage by 0.06%.
The diff coverage is 25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1239      +/-   ##
===========================================
- Coverage    83.34%   83.28%   -0.07%     
===========================================
  Files          117      117              
  Lines        12904    12908       +4     
===========================================
- Hits         10755    10750       -5     
- Misses        2149     2158       +9
Impacted Files Coverage Δ
src/formattedcode/output_csv.py 84.72% <25%> (-1.71%) ⬇️
src/scancode/cli.py 76.49% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81f177e...6dbe131. Read the comment docs.

@pombredanne
Copy link
Member Author

All tests passing so good to merge.

@pombredanne pombredanne merged commit 58dfec6 into develop Oct 31, 2018
@pombredanne pombredanne deleted the 1238-lic-expression-csv branch October 31, 2018 16:29
pombredanne pushed a commit that referenced this pull request Jul 14, 2021
* Add CDDL lexer (thanks to Fabian Neumann)

* Add CDDL to mappings

* Fix inline flag in CDDL regex

* Update AUTHORS

* Fix explosive backtracking

* Comment invalid CDDL syntax for automated tests

* Update following Georg Brandl's review

* Update tests for CDDL to new framework

* Pylint pass

* Update links to CDDL RFC

* Update copyright header

* Solve regexlint issues in CDDL parser

* Add link to CDDL in documentation
pombredanne pushed a commit that referenced this pull request Sep 8, 2022
* Add CDDL lexer (thanks to Fabian Neumann)

* Add CDDL to mappings

* Fix inline flag in CDDL regex

* Update AUTHORS

* Fix explosive backtracking

* Comment invalid CDDL syntax for automated tests

* Update following Georg Brandl's review

* Update tests for CDDL to new framework

* Pylint pass

* Update links to CDDL RFC

* Update copyright header

* Solve regexlint issues in CDDL parser

* Add link to CDDL in documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant