Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notice about Python 3 #1807

Closed
wants to merge 3 commits into from
Closed

Conversation

filips123
Copy link

Add notice that Python 2.7 up to 3.6.8 is supported to README. This should be correct, but please review if any of installation methods don't work.

Also, this should also be added to repository wiki. I will do this after I'm sure that all changes here are correct.

@pombredanne @Abhishek-Dev09

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ++!
I posted a few comments: we need to be sure that the package names for Python 3.6 are correct as otherwise this would generate confusion.

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Show resolved Hide resolved

* On RPM distros use:
``sudo yum install python-devel xz-libs zlib libxml2-devel libxslt-devel bzip2-libs``
``sudo yum install python3.6-devel xz-libs zlib libxml2-devel libxslt-devel bzip2-libs``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, are you sure that python3.6-devel is the correct package name and is available?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfourtunately, Yum handles varsions a bit diffrent. Because of that, python36-devel does not exist and only Python 3.7 is availible.

(Tested on Fedora in Docker)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You rock 🙇‍♂️ ... but what about EPEL?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that EPEL also does not have Python 3.6 version of python-devel...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case if Python 2.7 is still supported, I can update instructions to only use Python 2.7 on RPM.

But the real solution would be to update ScanCode to support newer versions of Python and then also update instructions to just install any (newer) Python 3 version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to just install any (newer) Python 3 version.

Yes, but we will never support anything before Python 3.6

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But is now Python 3.7 supported?

@filips123
Copy link
Author

I will check if that package names are correct tomorrow.

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks... I will merge once you add the extra things you mentioned.

README.rst Show resolved Hide resolved
Signed-off-by: Filip Š <filip.stamcar@hotmail.com>
Signed-off-by: Filip Š <filip.stamcar@hotmail.com>
Signed-off-by: Filip Š <filip.stamcar@hotmail.com>
@pombredanne
Copy link
Member

@filips123 are we all set? Do you mind to rebase so I can review and merge?

@pombredanne
Copy link
Member

@filips123 ping

@filips123
Copy link
Author

The problem is Python 3.6 handling in distributions that use Yum. I think that they just have 3.7+ available.

The solution for this is to check if ScanCode supports 3.7 and newer versions (and obviously support them if they are not supported already), and then fix instructions to install any newer version.

Copy link
Collaborator

@rpotter12 rpotter12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filips123 Resolve conflicts

@filips123
Copy link
Author

Recent README and documentation changes were already updated to recommend Python 3.6.8 so this PR is not needed anymore.

@filips123 filips123 closed this May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants