Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename first column of csv output to "path" #2016

Merged
merged 5 commits into from
Jan 8, 2022

Conversation

JRavi2
Copy link
Contributor

@JRavi2 JRavi2 commented Apr 22, 2020

Signed-off-by: Ravi jravi248@gmail.com

Fixes #2009

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #2016 into develop will increase coverage by 0.55%.
The diff coverage is 44.44%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2016      +/-   ##
===========================================
+ Coverage    78.98%   79.54%   +0.55%     
===========================================
  Files          131      131              
  Lines        16944    16944              
===========================================
+ Hits         13384    13478      +94     
+ Misses        3560     3466      -94     
Impacted Files Coverage Δ
src/formattedcode/output_csv.py 56.35% <44.44%> (ø)
src/scancode/cli.py 77.82% <0.00%> (+0.27%) ⬆️
src/extractcode/libarchive2.py 94.08% <0.00%> (+0.28%) ⬆️
src/summarycode/plugin_consolidate.py 94.26% <0.00%> (+0.40%) ⬆️
src/scancode/resource.py 86.99% <0.00%> (+0.41%) ⬆️
src/licensedcode/index.py 73.42% <0.00%> (+0.45%) ⬆️
src/packagedcode/jar_manifest.py 89.69% <0.00%> (+0.51%) ⬆️
src/scancode/api.py 95.54% <0.00%> (+0.63%) ⬆️
src/typecode/pygments_lexers.py 52.90% <0.00%> (+0.64%) ⬆️
src/packagedcode/pypi.py 87.34% <0.00%> (+0.81%) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 794c7f1...e4237cc. Read the comment docs.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Ravi <jravi248@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2021

Codecov Report

Merging #2016 (e4237cc) into develop (794c7f1) will increase coverage by 0.55%.
The diff coverage is 44.44%.

❗ Current head e4237cc differs from pull request most recent head f82bf79. Consider uploading reports for the commit f82bf79 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2016      +/-   ##
===========================================
+ Coverage    78.98%   79.54%   +0.55%     
===========================================
  Files          131      131              
  Lines        16944    16944              
===========================================
+ Hits         13384    13478      +94     
+ Misses        3560     3466      -94     
Impacted Files Coverage Δ
src/formattedcode/output_csv.py 56.35% <44.44%> (ø)
src/scancode/cli.py 77.82% <0.00%> (+0.27%) ⬆️
src/extractcode/libarchive2.py 94.08% <0.00%> (+0.28%) ⬆️
src/summarycode/plugin_consolidate.py 94.26% <0.00%> (+0.40%) ⬆️
src/scancode/resource.py 86.99% <0.00%> (+0.41%) ⬆️
src/licensedcode/index.py 73.42% <0.00%> (+0.45%) ⬆️
src/packagedcode/jar_manifest.py 89.69% <0.00%> (+0.51%) ⬆️
src/scancode/api.py 95.54% <0.00%> (+0.63%) ⬆️
src/typecode/pygments_lexers.py 52.90% <0.00%> (+0.64%) ⬆️
src/packagedcode/pypi.py 87.34% <0.00%> (+0.81%) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 794c7f1...f82bf79. Read the comment docs.

@JRavi2 JRavi2 closed this Sep 5, 2021
@pombredanne
Copy link
Member

@JRavi2 hey :) please do not close this as it will be merged!
This is waiting some unrelated changes first.

@pombredanne pombredanne reopened this Sep 6, 2021
@JRavi2
Copy link
Contributor Author

JRavi2 commented Sep 6, 2021

Oh, sorry about that. The PR was looking a bit messy and was idle for a while, so I closed it.
No worries, won't close it again :). Also, there were some merge conflicts, I've fixed them up.

@pombredanne pombredanne merged commit d9ba058 into nexB:develop Jan 8, 2022
@pombredanne
Copy link
Member

Merged at last! Thank you for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change name of first column in CSV output from "Resource" to "path"
3 participants