Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dead link in issue templates #2030 #2031

Merged

Conversation

is2ei
Copy link
Contributor

@is2ei is2ei commented May 9, 2020

Fixes #2030

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

Signed-off-by: Issei Horie <issei.horie@is2ei.com>
@codecov
Copy link

codecov bot commented May 9, 2020

Codecov Report

Merging #2031 into develop will increase coverage by 0.60%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2031      +/-   ##
===========================================
+ Coverage    78.98%   79.59%   +0.60%     
===========================================
  Files          131      131              
  Lines        16944    16944              
===========================================
+ Hits         13384    13486     +102     
+ Misses        3560     3458     -102     
Impacted Files Coverage Δ
src/extractcode/libarchive2.py 94.08% <0.00%> (+0.28%) ⬆️
src/licensedcode/match.py 78.06% <0.00%> (+0.36%) ⬆️
src/summarycode/plugin_consolidate.py 94.26% <0.00%> (+0.40%) ⬆️
src/scancode/resource.py 86.99% <0.00%> (+0.41%) ⬆️
src/licensedcode/index.py 73.42% <0.00%> (+0.45%) ⬆️
src/packagedcode/jar_manifest.py 89.69% <0.00%> (+0.51%) ⬆️
src/scancode/cli.py 78.09% <0.00%> (+0.55%) ⬆️
src/typecode/pygments_lexers.py 52.90% <0.00%> (+0.64%) ⬆️
src/packagedcode/pypi.py 87.34% <0.00%> (+0.81%) ⬆️
src/formattedcode/output_spdx.py 79.58% <0.00%> (+1.04%) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 794c7f1...9d575d6. Read the comment docs.

@is2ei
Copy link
Contributor Author

is2ei commented May 9, 2020

Hi, @pombredanne

It looks the issue #2030 causes CI failure in other PRs. So I think this PR should be merged ASAP.
Could you review this?

Copy link
Contributor

@steven-esser steven-esser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pombredanne pombredanne merged commit 72850bd into nexB:develop Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link is dead in issue templates
4 participants