packaged code to handle Pipfile.lock

[rpotter12]

Fixes #2082
Packagedcode to handle Pipfile.lock

Tasks

• Reviewed contribution guidelines
• PR is descriptively titled 📑 and links the original issue above 🔗
• Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
  Run tests locally to check for errors.
• Commits are in uniquely-named feature branch and has no merge conflicts 📁

[steven-esser]

@rpotter12 Just one minor change left :)

Then this looks good to me.

[steven-esser]

This looks good to me.

@pombredanne Anything to add here?

[pombredanne]

This is looking great and I just have a few minor nits.

[pombredanne]

Do you know what is this sha256 about? A download archive? the original Pipfile?

[steven-esser]

@pombredanne This was originally brought up by me. It the the sha256 of the original pipfile (I think). Since it was in the data, I suggested we should collect it. We may not want to do this, as it is slightly confusing. Also, I am unsure if this particular hash will be present in most pipfiles.

[rpotter12]

@pombredanne The sha256 which we are collecting in this packagedcode is of original pipfile. So I think we should detect this and add this in sha256 :)

[pombredanne]

ok, please enter a ticket to revisit this. I am not sure we can do much of anything with this as this is not the sha256 of some package archive of sorts?

[pombredanne]

Do you think we should add these checksums to the packagedcode model?

[steven-esser]

@pombredanne This was originally brought up by me. It the the sha256 of the original pipfile (I think). Since it was in the data, I suggested we should collect it. We may not want to do this, as it is slightly confusing. Also, I am unsure if this particular hash will be present in most pipfiles.

[rpotter12]

@pombredanne The checksums for which you talking about is of dependencies and I know only little bit about checksums. I think if we don't add sha256 in our packagedcode model that will also be good.

[rpotter12]

Maybe If we need to collect these, we can create a new ticket for this. :)

[pombredanne]

LGTM. Thank you!