Add new OIL License #2423
Merged
Add new OIL License #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating
Updating
Updating my fork
Updating my fork
Updating my fork
pombredanne
requested changes
Mar 8, 2021
There was a problem hiding this comment.
Thanks!
I have a few comments for your consideration.
IMHO the correct text_url would be this:
- other_urls could have something such as
- homepage_url should be https://github.com/StarkDrones/OPNL
- The license key should be
opnl-1.0andopnl-2.0respectively as their authors name them asOPNLnotOIL
| name: Open Innovation License version 1.0 | ||
| category: Permissive | ||
| owner: Stark Drones Corporation | ||
| notes: From https://github.com/StarkDrones/OPNLv1/blob/main/.github/LICENSE.md |
There was a problem hiding this comment.
Suggested change
| notes: From https://github.com/StarkDrones/OPNLv1/blob/main/.github/LICENSE.md | |
| other_urls: | |
| - https://github.com/StarkDrones/OPNLv1/blob/main/.github/LICENSE.md |
| category: Permissive | ||
| owner: Stark Drones Corporation | ||
| notes: From https://github.com/StarkDrones/OPNLv1/blob/main/.github/LICENSE.md | ||
| homepage_url: https://www.en.patent.aau.dk/open-innovation-licensing/ |
There was a problem hiding this comment.
I do not think this is the home page and that this Danish outfit is related to this license here. They vaguely use similar names. Or may be I am missing something?
| category: Permissive | ||
| owner: Stark Drones Corporation | ||
| notes: From https://github.com/StarkDrones/OPNLv2/blob/main/.github/LICENSE.md | ||
| homepage_url: https://www.en.patent.aau.dk/open-innovation-licensing/ |
There was a problem hiding this comment.
Same comment as above for notes and homepage
There was a problem hiding this comment.
Hey! @pombredanne I have made the requested changes . Please review !
Do not fail with empty lists
steven-esser
suggested changes
Mar 23, 2021
|
@akugarg LGTM! 馃憤 we just need a rebase before we can merge:) |
Signed-off-by: akugarg <akanksha.garg2k@gmail.com>
pombredanne
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akanksha Garg akanksha.garg2k@gmail.com
Fixes #2384
Tasks
Run tests locally to check for errors.