Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add referenced_filenames as a resource attribute #2629

Closed
wants to merge 1 commit into from

Conversation

akugarg
Copy link
Collaborator

@akugarg akugarg commented Aug 9, 2021

Signed-off-by: akugarg akanksha.garg2k@gmail.com
This PR adds on an extra resource attribute "referenced_filenames" which should be returned by API function
See more at #2616 (comment)

Fixes #0000

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • Tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 馃搧

Signed-off-by: akugarg <akanksha.garg2k@gmail.com>
@akugarg akugarg closed this Aug 9, 2021
@pombredanne
Copy link
Member

@akugarg I see you closed this, but I assume this is because you do not want this as a resource attribute, but rather as something tied to the matched rule of license match?

@akugarg
Copy link
Collaborator Author

akugarg commented Aug 9, 2021

Yes I was thinking too in this direction only
Any suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants