rules with "unqualified" license names are references, not notices #2759

petergardfjall · 2021-11-17T12:29:07Z

This PR changes a number of rules with unqualified license names (such as Apache 2.0 License) to be classified as (the weaker) reference rather than (the stronger) notice.

To be precise, this PR changes the is_license_notice property to an is_license_reference property for the aforementioned rules.

I'm sure there are more occurrences like these. I just picked a few that I found. Also, I'm not entirely sure if this is the correct classification (please let know if you disagree). I am also not entirely sure if this will have any real impact (besides a more strict adherence to the nomenclature as described here)

Tasks

Reviewed contribution guidelines
PR is descriptively titled 📑 and links the original issue above 🔗
Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
Run tests locally to check for errors.
Commits are in uniquely-named feature branch and has no merge conflicts 📁

pombredanne · 2021-11-17T12:59:31Z

Whoa! This is an awesome find!
You think you could pull a quick list of the rule name and texts to paste in a comment here? That would help a lot with the review since the texts are not changed!

How did you find all theses quirks?

petergardfjall · 2021-11-17T13:03:57Z

src/licensedcode/data/rules/agpl-3.0-plus_105.yml

@@ -1,3 +1,3 @@
 license_expression: agpl-3.0-plus
-is_license_notice: yes
+is_license_reference: yes


AGPL 3 or later

petergardfjall · 2021-11-17T13:04:14Z

src/licensedcode/data/rules/apache-2.0_136.yml

@@ -1,5 +1,5 @@
 license_expression: apache-2.0
-is_license_notice: yes
+is_license_reference: yes


The Apache License, Version 2.0 http://www.apache.org/licenses/LICENSE-2.0.txt

petergardfjall · 2021-11-17T13:04:47Z

src/licensedcode/data/rules/apache-2.0_170.yml

@@ -1,5 +1,5 @@
 license_expression: apache-2.0
-is_license_notice: yes
+is_license_reference: yes


[Apache License version 2](http://www.apache.org/licenses/

petergardfjall · 2021-11-17T13:05:02Z

src/licensedcode/data/rules/apache-2.0_175.yml

@@ -1,3 +1,3 @@
 license_expression: apache-2.0
-is_license_notice: yes
+is_license_reference: yes


the Apache 2.0 license.

petergardfjall · 2021-11-17T13:05:13Z

src/licensedcode/data/rules/apache-2.0_176.yml

@@ -1,3 +1,3 @@
 license_expression: apache-2.0
-is_license_notice: yes
+is_license_reference: yes


Apache 2.0 license.

petergardfjall · 2021-11-17T13:05:27Z

src/licensedcode/data/rules/apache-2.0_417.yml

@@ -1,3 +1,3 @@
 license_expression: apache-2.0
-is_license_notice: yes
+is_license_reference: yes


the Apache license.

petergardfjall · 2021-11-17T13:05:37Z

src/licensedcode/data/rules/apache-2.0_767.yml

@@ -1,5 +1,5 @@
 license_expression: apache-2.0
-is_license_notice: yes
+is_license_reference: yes


[Apache License version 2](https://www.apache.org/licenses/

petergardfjall · 2021-11-17T13:05:48Z

src/licensedcode/data/rules/bitstream_3.yml

@@ -1,3 +1,3 @@
 license_expression: bitstream
-is_license_notice: yes
+is_license_reference: yes


the Bitstream Vera License

petergardfjall · 2021-11-17T13:05:58Z

src/licensedcode/data/rules/bitstream_4.yml

@@ -1,3 +1,3 @@
 license_expression: bitstream
-is_license_notice: yes
+is_license_reference: yes


Bitstream Vera License

petergardfjall · 2021-11-17T13:06:10Z

src/licensedcode/data/rules/bitstream_5.yml

@@ -1,3 +1,3 @@
 license_expression: bitstream
-is_license_notice: yes
+is_license_reference: yes


Bitstream License

petergardfjall · 2021-11-17T13:06:23Z

src/licensedcode/data/rules/bsd-new_394.yml

@@ -1,4 +1,4 @@
 license_expression: bsd-new
-is_license_notice: yes
+is_license_reference: yes


BSD3 License

petergardfjall · 2021-11-17T13:06:32Z

src/licensedcode/data/rules/lgpl-2.0-plus_454.yml

@@ -1,3 +1,3 @@
 license_expression: lgpl-2.0-plus
-is_license_notice: yes
+is_license_reference: yes


"LGPL version 2 or later",

petergardfjall · 2021-11-17T13:06:43Z

src/licensedcode/data/rules/lgpl-2.1-plus_162.yml

@@ -1,3 +1,3 @@
 license_expression: lgpl-2.1-plus
-is_license_notice: yes
+is_license_reference: yes


lesser General Public License

petergardfjall · 2021-11-17T13:06:55Z

src/licensedcode/data/rules/lgpl-2.1_162.yml

@@ -1,3 +1,3 @@
 license_expression: lgpl-2.1
-is_license_notice: yes
+is_license_reference: yes


lesser General Public License Version 2.1

petergardfjall · 2021-11-17T13:07:05Z

src/licensedcode/data/rules/lgpl-3.0_98.yml

@@ -1,3 +1,3 @@
 license_expression: lgpl-3.0
-is_license_notice: yes
+is_license_reference: yes


GNU lesser General Public License Version 3.0

petergardfjall · 2021-11-17T13:07:16Z

src/licensedcode/data/rules/lgpl-3.0_99.yml

@@ -1,3 +1,3 @@
 license_expression: lgpl-3.0
-is_license_notice: yes
+is_license_reference: yes


lesser General Public License Version 3.0

petergardfjall · 2021-11-17T13:07:27Z

src/licensedcode/data/rules/mit_428.yml

@@ -1,5 +1,5 @@
 license_expression: mit
-is_license_notice: yes
+is_license_reference: yes


The MIT License (MIT) - http://www.opensource.org/licenses/mit-license.php

petergardfjall · 2021-11-17T13:07:38Z

src/licensedcode/data/rules/mit_429.yml

@@ -1,5 +1,5 @@
 license_expression: mit
-is_license_notice: yes
+is_license_reference: yes


The MIT License (MIT) - https://www.opensource.org/licenses/mit-license.php

petergardfjall · 2021-11-17T13:07:52Z

src/licensedcode/data/rules/mit_434.yml

@@ -1,5 +1,5 @@
 license_expression: mit
-is_license_notice: yes
+is_license_reference: yes


The MIT License (MIT): http://opensource.org/licenses/MIT

petergardfjall · 2021-11-17T13:10:00Z

src/licensedcode/data/rules/odbl-1.0_1.yml

@@ -1,5 +1,5 @@
 license_expression: odbl-1.0
-is_license_notice: yes
+is_license_reference: yes


Open Database License http://www.opendatacommons.org/licenses/odbl/

petergardfjall · 2021-11-17T13:10:11Z

src/licensedcode/data/rules/public-domain_or_apache-2.0_1.yml

@@ -1,3 +1,3 @@
 license_expression: public-domain OR apache-2.0
-is_license_notice: yes
+is_license_reference: yes


Public Domain or Apache 2.0 license

petergardfjall · 2021-11-17T13:10:22Z

src/licensedcode/data/rules/redis-source-available-1.0_5.yml

@@ -1,3 +1,3 @@
 license_expression: redis-source-available-1.0
-is_license_notice: yes
+is_license_reference: yes


Redis Source Available License Agreement

petergardfjall · 2021-11-17T13:10:30Z

src/licensedcode/data/rules/unlicense_25.yml

@@ -1,5 +1,5 @@
 license_expression: unlicense
-is_license_notice: yes
+is_license_reference: yes


Public domain - http://unlicense.org

petergardfjall · 2021-11-17T13:14:38Z

Whoa! This is an awesome find! You think you could pull a quick list of the rule name and texts to paste in a comment here? That would help a lot with the review since the texts are not changed!

I should've done that from the start, but I've commented on each change what the matching rule contains.

How did you find all theses quirks?

Basically I first discovered it by coincidence while looking at a result file, and decided to make a small script to look for more such "wrongly classified" rules.

I used this (admittedly hacky 🙈) script. One still has to go through the output since it still contains quite a few rules correctly labelled as notices.

#!/bin/bash


rules_dir="src/licensedcode/data/rules"
rule_files=$(ls -1 ${rules_dir}/*.RULE)
for rule_file in ${rule_files}; do
    rule_name="${rule_file%.RULE}"
    rule_yaml="${rule_name}.yml"

    if egrep -E 'is_license_notice: yes' ${rule_yaml} > /dev/null; then
        lines=$(wc -l ${rule_file} | cut -d' ' -f 1)
        # only consider single-line rules
        if [[ ${lines} -eq 0 ]]; then

            #
            # filter out rules that have "qualifying text" that highly indicate
            # an actual license notice.
            #
            qualfiying_words=("provided" "under" "unter" "terms" "licensed" "license is" "available under" "released" "distributed" "this" "these" "applicable" "distribution" "license:" "licensing:" "available" "covered by" "subject to" "uses" "project" "project uses" "use the" "applicable" "includes" "inherits" "governed by" "applies" "@license" "is copyrighted by")

            for qualifying_word in "${qualfiying_words[@]}"; do
                if cat ${rule_file} | grep -i "${qualifying_word}" > /dev/null; then
                    continue 2 # continue the outer loop
                fi
            done

            echo "*** ${rule_name}: ${rule_file} ${rule_yaml} ***"
            echo "single-line notice:";
            cat ${rule_file}
            echo
            echo
        fi
    fi
done

pombredanne

This is great... I have a few nitpickings for your consideration:

Can you shorten the first line of your commit message, so it is under 50 chars? May be like "Requalify some notice license rules as references"
Do you mind to squash the commits? This should also take care of the DCO bot complaints as 4152ea7 is missing a signoff
there are two failing tests that used to have some scan details with license detection results using some of the rules that you are re-qualifying. You could regenerate the expected results with this:

$ sed -i -e "s|regen=False|regen=True|g" tests/summarycode/test_score.py tests/packagedcode/test_debian_copyright.py

$ pytest -vvs tests/summarycode/test_score.py::TestLicenseScore::test_license_clarity_score_spdx_licenses tests/packagedcode/test_debian_copyright.py::TestDebianCopyrightLicenseDetection::test_debian_parse_copyright_file_detailed_main_g_glib2_0_stable_copyright

$ sed -i -e "s|regen=True|regen=False|g" tests/summarycode/test_score.py tests/packagedcode/test_debian_copyright.py

petergardfjall · 2021-11-18T12:55:31Z

src/licensedcode/data/rules/apache-2.0_893.yml

@@ -1,5 +1,5 @@
 license_expression: apache-2.0
-is_license_notice: yes
+is_license_reference: yes


The Apache License, Version 2.0 https://www.apache.org/licenses/LICENSE-2.0.txt

petergardfjall · 2021-11-18T12:55:49Z

src/licensedcode/data/rules/bsd-2-clause-views_32.yml

@@ -1,5 +1,5 @@
 license_expression: bsd-2-clause-views
-is_license_notice: yes
+is_license_reference: yes


BSD 3-Clause License : http://www.freebsd.org/copyright/freebsd-license.html

petergardfjall · 2021-11-18T12:58:38Z

src/licensedcode/data/rules/cmu-uc_7.yml

@@ -1,4 +1,4 @@
 license_expression: secret-labs-2011
-is_license_notice: yes
+is_license_reference: yes


PIL Software License

petergardfjall · 2021-11-18T12:58:49Z

src/licensedcode/data/rules/ecosrh-1.1_2.yml

@@ -1,3 +1,3 @@
 license_expression: ecosrh-1.1
-is_license_notice: yes
+is_license_reference: yes


Red Hat eCos Public License v1.1

petergardfjall · 2021-11-18T13:01:00Z

src/licensedcode/data/rules/gpl-2.0-plus_20.yml

@@ -1,3 +1,3 @@
 license_expression: gpl-2.0-plus
-is_license_notice: yes
+is_license_reference: yes


GNU General Public License v2.0 or later

petergardfjall · 2021-11-18T13:01:15Z

src/licensedcode/data/rules/gpl-2.0_617_1.yml

@@ -1,8 +1,9 @@
 license_expression: gpl-2.0
-is_license_notice: yes
+is_license_reference: yes


ftp://prep.ai.mit.edu/pub/gnu/GPL

petergardfjall · 2021-11-18T13:01:26Z

src/licensedcode/data/rules/gpl-2.0_666.yml

@@ -1,3 +1,3 @@
 license_expression: gpl-2.0
-is_license_notice: yes
+is_license_reference: yes


GPL v2 License

petergardfjall · 2021-11-18T13:01:39Z

src/licensedcode/data/rules/gpl_234.yml

@@ -1,3 +1,3 @@
 license_expression: gpl-1.0-plus
-is_license_notice: yes
+is_license_reference: yes


General Public License

petergardfjall · 2021-11-18T13:01:51Z

src/licensedcode/data/rules/gpl-3.0-plus_309.yml

@@ -1,3 +1,3 @@
 license_expression: gpl-3.0-plus
-is_license_notice: yes
+is_license_reference: yes


GNU GPL v3 or above

petergardfjall · 2021-11-18T13:02:03Z

src/licensedcode/data/rules/gpl-3.0-plus_77.yml

@@ -1,3 +1,3 @@
 license_expression: gpl-3.0-plus
-is_license_notice: yes
+is_license_reference: yes


GNU General Public License version 3, or any later version

petergardfjall · 2021-11-18T13:02:23Z

src/licensedcode/data/rules/lgpl-2.0_71.yml

@@ -1,3 +1,3 @@
 license_expression: lgpl-2.0
-is_license_notice: yes
+is_license_reference: yes


GNU Library General Public License Version 2.

petergardfjall · 2021-11-18T13:02:36Z

src/licensedcode/data/rules/lgpl-2.1-plus_286.yml

@@ -1,4 +1,4 @@
 license_expression: lgpl-2.1-plus
-is_license_notice: yes
+is_license_reference: yes


GNU Lesser General Public License (LGPLv2.1+)

petergardfjall · 2021-11-18T13:02:45Z

src/licensedcode/data/rules/lgpl-3.0-plus_186.yml

@@ -1,3 +1,3 @@
 license_expression: lgpl-3.0-plus
-is_license_notice: yes
+is_license_reference: yes


"LGPL version 3 or later",

petergardfjall · 2021-11-18T13:03:09Z

src/licensedcode/data/rules/proprietary_greensock_3.yml

@@ -1,5 +1,5 @@
 license_expression: proprietary-license
-is_license_notice: yes
+is_license_reference: yes


http://greensock.com/standard-license

petergardfjall · 2021-11-18T13:03:20Z

src/licensedcode/data/rules/proprietary_greensock_8.yml

@@ -1,5 +1,5 @@
 license_expression: proprietary-license
-is_license_notice: yes
+is_license_reference: yes


http://www.greensock.com

petergardfjall · 2021-11-18T13:17:39Z

I added some more corrections and tried to address your comments.

Can you shorten the first line of your commit message, so it is under 50 chars? May be like "Requalify some notice license rules as references"

✔️

Do you mind to squash the commits? This should also take care of the DCO bot complaints as 4152ea7 is missing a signoff

✔️

there are two failing tests that used to have some scan details with license detection results using some of the rules that you are re-qualifying. You could regenerate the expected results with this:

A few local test case failures. Let's see if they show up here as well. Perhaps you can direct me @pombredanne ?

This changes a number of rules with unqualified license names (such as "Apache 2.0 License") to be classified as (the weaker) "reference" rather than (the stronger) notice. In practice, this means that the `is_license_notice` property is changed to `is_license_reference` for a number of rules. Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com>

pombredanne

Looking great!
Almost merge ready: for the failing tests you would need to run the tests once with the regen=True flags locally, then restore the regen=False and commit only the updated JSON expected files.

pombredanne · 2021-11-18T15:15:27Z

tests/packagedcode/test_debian_copyright.py

@@ -26,7 +26,7 @@
 def check_expected_parse_copyright_file(
    test_loc,
    expected_loc,
-    regen=False,
+    regen=True,


You need to revert this to "regen=False", the regen True was only for local regeneration ... otherwise the tests are testing nothing. And you would need to commit the updated expected JSON test results too

pombredanne · 2021-11-18T15:15:53Z

tests/summarycode/test_score.py

@@ -31,7 +31,7 @@
 test_env.test_data_dir = os.path.join(os.path.dirname(__file__), 'data')


-def make_test_function(test_name, test_dir, expected_file, regen=False):
+def make_test_function(test_name, test_dir, expected_file, regen=True):


Same as above: You need to revert this to "regen=False", the regen True is only for local regeneration and cannot be committed... otherwise the tests are testing nothing.
And you would need to commit the updated expected JSON test results too

pombredanne · 2021-11-19T06:55:01Z

So just to make sure you did not miss this, this would be what to do and it is important to do all these steps before a commit:

$ sed -i -e "s|regen=False|regen=True|g" tests/summarycode/test_score.py tests/packagedcode/test_debian_copyright.py

$ pytest -vvs tests/summarycode/test_score.py::TestLicenseScore::test_license_clarity_score_spdx_licenses tests/packagedcode/test_debian_copyright.py::TestDebianCopyrightLicenseDetection::test_debian_parse_copyright_file_detailed_main_g_glib2_0_stable_copyright

$ sed -i -e "s|regen=True|regen=False|g" tests/summarycode/test_score.py tests/packagedcode/test_debian_copyright.py

The commit would contains the updated, regenerated JSON or YAML fixtures for each of the two previously failing tests:

for test_license_clarity_score_spdx_licenses these files are:
- tests: tests/summarycode/data/score/spdx_licenses
- expected: tests/summarycode/data/score/spdx_licenses-expected.json <--- this will be regenerated with the procedure above and needs to be reviewed and committed
for test_debian_parse_copyright_file_detailed_main_g_glib2_0_stable_copyright these files are:
- tests: tests/packagedcode/data/debian/copyright/debian-2019-11-15/main/g/glib2.0/stable_copyright
- expected: tests/packagedcode/data/debian/copyright/debian-2019-11-15/main/g/glib2.0/stable_copyright-detailed.expected.yml <--- this will be regenerated with the procedure above and needs to be reviewed and committed

petergardfjall · 2021-11-23T15:42:38Z

So just to make sure you did not miss this, this would be what to do and it is important to do all these steps before a commit:

$ sed -i -e "s|regen=False|regen=True|g" tests/summarycode/test_score.py tests/packagedcode/test_debian_copyright.py

$ pytest -vvs tests/summarycode/test_score.py::TestLicenseScore::test_license_clarity_score_spdx_licenses tests/packagedcode/test_debian_copyright.py::TestDebianCopyrightLicenseDetection::test_debian_parse_copyright_file_detailed_main_g_glib2_0_stable_copyright

$ sed -i -e "s|regen=True|regen=False|g" tests/summarycode/test_score.py tests/packagedcode/test_debian_copyright.py

The commit would contains the updated, regenerated JSON or YAML fixtures for each of the two previously failing tests:

for test_license_clarity_score_spdx_licenses these files are:

tests: tests/summarycode/data/score/spdx_licenses

expected: tests/summarycode/data/score/spdx_licenses-expected.json <--- this will be regenerated with the procedure above and needs to be reviewed and committed

for test_debian_parse_copyright_file_detailed_main_g_glib2_0_stable_copyright these files are:

tests: tests/packagedcode/data/debian/copyright/debian-2019-11-15/main/g/glib2.0/stable_copyright

expected: tests/packagedcode/data/debian/copyright/debian-2019-11-15/main/g/glib2.0/stable_copyright-detailed.expected.yml <--- this will be regenerated with the procedure above and needs to be reviewed and committed

I've tried to correct this but I have to admit that I don't fully understand the test structure nor what you are suggesting above. Some tests are still failing.

pombredanne · 2021-11-23T16:27:54Z

@petergardfjall fair enough... I reckon this is not clear!
Let me push a commit to your branch and list exactly the commands I ran here

pombredanne · 2021-11-25T13:41:12Z

@petergardfjall in 72a6d9c

I ran this sequence after pulling your branch:

sed -i -e "s|regen=False|regen=True|g" tests/summarycode/test_score.py
pytest -vvs --test-suite=validate tests/summarycode/test_score.py::TestLicenseScore::test_license_clarity_score_spdx_licenses
sed -i -e "s|regen=True|regen=False|g" tests/summarycode/test_score.py

Then I doubled checked there were no leftover regens: grep -r tests/ -e "regen=True"

git status
On branch change-notices-to-references
Your branch is up to date with 'petergardfjall/change-notices-to-references'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   tests/summarycode/data/score/spdx_licenses-expected.json

then committed the updated tests/summarycode/data/score/spdx_licenses-expected.json

I guess what tripped you is the --test-suite test markers which are not super well documented (that's an understatement)

pombredanne

Almost ready to merge!
If could could just amend the commit message for 162b2ae with your DCO signoff we are done.
Thanks!

Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com>

petergardfjall · 2021-11-26T09:05:16Z

Almost ready to merge! If could could just amend the commit message for 162b2ae with your DCO signoff we are done. Thanks!

Thank you so much for the help! I've made the changes you suggested, and updated the DCO. The tests pass. 🎉

pombredanne

LGTM. Thanks!

petergardfjall force-pushed the change-notices-to-references branch from 54e7715 to e94a9ca Compare November 17, 2021 12:51

petergardfjall commented Nov 17, 2021

View reviewed changes

pombredanne requested changes Nov 18, 2021

View reviewed changes

petergardfjall force-pushed the change-notices-to-references branch from 4152ea7 to 02a2a10 Compare November 18, 2021 12:54

petergardfjall commented Nov 18, 2021

View reviewed changes

petergardfjall force-pushed the change-notices-to-references branch 2 times, most recently from cb51363 to 6ea7036 Compare November 18, 2021 13:00

petergardfjall commented Nov 18, 2021

View reviewed changes

petergardfjall force-pushed the change-notices-to-references branch from 6ea7036 to 0151350 Compare November 18, 2021 13:18

pombredanne requested changes Nov 18, 2021

View reviewed changes

pombredanne requested changes Nov 25, 2021

View reviewed changes

revert regen=True change

caa2926

Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com>

petergardfjall force-pushed the change-notices-to-references branch from 72a6d9c to caa2926 Compare November 26, 2021 06:43

fix broken tests

b650b1a

Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com>

pombredanne approved these changes Nov 26, 2021

View reviewed changes

pombredanne merged commit 1fdf40f into nexB:develop Nov 26, 2021

rules with "unqualified" license names are references, not notices #2759

rules with "unqualified" license names are references, not notices #2759

Conversation

petergardfjall commented Nov 17, 2021 • edited by pombredanne Loading

Tasks

pombredanne commented Nov 17, 2021

petergardfjall Nov 17, 2021 • edited Loading

Choose a reason for hiding this comment

petergardfjall Nov 17, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

petergardfjall commented Nov 17, 2021 • edited Loading

pombredanne left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

petergardfjall commented Nov 18, 2021

pombredanne left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pombredanne commented Nov 19, 2021 • edited Loading

petergardfjall commented Nov 23, 2021

pombredanne commented Nov 23, 2021 • edited Loading

pombredanne commented Nov 25, 2021

pombredanne left a comment

Choose a reason for hiding this comment

petergardfjall commented Nov 26, 2021

pombredanne left a comment

Choose a reason for hiding this comment

petergardfjall commented Nov 17, 2021 •

edited by pombredanne

Loading

petergardfjall Nov 17, 2021 •

edited

Loading

petergardfjall Nov 17, 2021 •

edited

Loading

petergardfjall commented Nov 17, 2021 •

edited

Loading

pombredanne commented Nov 19, 2021 •

edited

Loading

pombredanne commented Nov 23, 2021 •

edited

Loading