Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix azure pipeline vmimage deprecations #2775

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Dec 1, 2021

macos-10.14 and vs2017-win2016 vm images are deprecated and
this replaces them with newer images.

See https://devblogs.microsoft.com/devops/hosted-pipelines-image-deprecation/

macos-10.14 would be deprecated on December 10, 2021
vs2017-win2016 would be deprecated on March 15, 2022

Signed-off-by: Ayan Sinha Mahapatra ayansmahapatra@gmail.com

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

`macos-10.14` and `vs2017-win2016` vm images are deprecated and
this replaces them with newer images.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think we should keep also the oldest supported versions first and it's OK to also add newest 11 and 2022 versions like you did... but we cannot only support the latest and greatest.

azure-pipelines.yml Show resolved Hide resolved
azure-pipelines.yml Show resolved Hide resolved
@AyanSinhaMahapatra
Copy link
Member Author

AyanSinhaMahapatra commented Dec 3, 2021

I looked into the images available here and here

In windows we already did the tests on windows-2019, it is just below the windows-2022 test. These are the only two images listed above.

In MacOS, there are only three, 10.14, 10.15 and 11, of which 10.14 will be deprecated and removed soon. So replaced those tests too.

Also note that I removed python 3.6 in the newer images, as they are not supported and not present so were generating errors.

Do you also mean the ordering on the tests in the azure-pipelines.yml file? Like the windows-2019 should be before the windows-2022 test?

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you also mean the ordering on the tests in the azure-pipelines.yml file? Like the windows-2019 should be before the windows-2022 test?

No, we are all good as it is ... thank you ++... merging!

@pombredanne pombredanne merged commit 1dfd73a into develop Dec 3, 2021
@pombredanne pombredanne deleted the fix-azure-deprecations branch December 3, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants