Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug recognizing license as license_notice instead of license_text #2817

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Fix bug recognizing license as license_notice instead of license_text #2817

merged 1 commit into from
Jan 31, 2022

Conversation

adityasangave
Copy link
Contributor

@adityasangave adityasangave commented Jan 28, 2022 •
edited
Loading

Fixes #2807

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

@adityasangave
Fix bug recognizing license as license_notice instead of license_text
6c018e2 
Signed-off-by: adii21-Ux <adityasangave2112@gmail.com>
pombredanne
pombredanne approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and clean: looking great!

@pombredanne pombredanne merged commit 8bd896a into nexB:develop Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Full text of CC-BY-4.0 is recognized as license notice instead of license text
2 participants
@adityasangave @pombredanne