-
-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
New license and copyright rule #2837
Conversation
@pombredanne review, any changes ? |
@@ -2562,6 +2562,9 @@ def build_detection_from_node( | |||
#holder is Tim Hudson (tjh@mincom.oz.au). | |||
COPYRIGHT: {<HOLDER> <JUNK> <NAME-EMAIL>} #83001 | |||
|
|||
# Copyright lowRISC contributors. | |||
COPYRIGHT: {<COPY> <NN> <CONTRIBUTORS>} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great! do you mind to add a test for this too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See https://github.com/nexB/scancode-toolkit/blob/develop/tests/cluecode/cluecode_test_utils.py and https://github.com/nexB/scancode-toolkit/tree/develop/tests/cluecode/data/copyrights for pairs of test file/expected results in YAML.
Signed-off-by: adii21-Ux <adityasangave2112@gmail.com>
Signed-off-by: adii21-Ux <adityasangave2112@gmail.com>
71a36fb
to
a8527a3
Compare
Signed-off-by: adii21-Ux <adityasangave2112@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great!
Thanks. Merging
Fixes #2798
Tasks
Run tests locally to check for errors.