Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect SPDX-FileContributor tags as authors #2838

Merged
merged 3 commits into from
Feb 2, 2022
Merged

Detect SPDX-FileContributor tags as authors #2838

merged 3 commits into from
Feb 2, 2022

Conversation

pombredanne
Copy link
Member

@pombredanne pombredanne commented Feb 2, 2022 •
edited
Loading

This is SPDX but not reuse compliant
but frequent enough per:
https://github.com/search?q="SPDX-FileContributor"&type=code

See #1816

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

@pombredanne
Add "contributor" to copyright hint words
281d689 
This will help detect SPDX-FileContributor tags

Reported-by: Rainer Thieringer @rainerth
Reference: #1816
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Detect SPDX-FileContributor as authors
34182c8 
Reported-by: Rainer Thieringer @rainerth
Reference: #1816
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne pombredanne mentioned this pull request Feb 2, 2022
Closed
@pombredanne
Copy link
Member Author

@rainerth ping

@pombredanne
Make copyright hint more specific.
dc78638 
This will help detect SPDX-FileContributor tags
But not plain "contributor" words

Reported-by: Rainer Thieringer @rainerth
Reference: #1816
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne pombredanne merged commit b86dc0d into develop Feb 2, 2022
@pombredanne pombredanne deleted the 1816-spdx-filecontributor branch February 2, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
copyright scan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@pombredanne