Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new copyright test cases #2891

Merged
merged 3 commits into from
Apr 20, 2022

Conversation

abhishak3
Copy link
Contributor

Issue #2299
Added some new copyright test cases.

Signed-off-by: Abhishek <abhishek.pandey.3237@gmail.com>
Signed-off-by: abhishak3 <abhishek.pandey.3237@gmail.com>
@abhishak3 abhishak3 changed the title New copyright status Added new copyright test cases Mar 18, 2022
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ++
This is looking great. Still need to review each results in details though.

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! See some minor changes to mark some tests as failing for now.
See

for an example.

tests/cluecode/data/copyrights/long_holder_name.txt.yml Outdated Show resolved Hide resolved
tests/cluecode/data/copyrights/long_name.txt.yml Outdated Show resolved Hide resolved
Nouns NNs and Prper nouns NNPs should be limited in length.
For now these texts are expected to fail until we add a limit, say of
50 characters.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! metrging now

@pombredanne pombredanne merged commit a1f3c12 into nexB:develop Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants