Rename precise_license_detection field #2967 #2968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update expected test results Signed-off-by: Jono Yang <jyang@nexb.com>
AyanSinhaMahapatra
approved these changes
May 19, 2022
There was a problem hiding this comment.
Looks great!
But since we are changing the output format, we need to update it according to this https://scancode-toolkit.readthedocs.io/en/latest/misc/versioning.html btw, the format is here and add a changelog :P
|
@AyanSinhaMahapatra Thanks! I knew I was missing something |
* List the new fields of the summary plugin and license clarity plugins in the changelog Signed-off-by: Jono Yang <jyang@nexb.com>
|
@AyanSinhaMahapatra @pombredanne I've updated the changelog with a list of the the new fields that we are using to replace the old field with in the license clarity score and summarizer plugins. Should I also bump the json output version here as well, or are we going to do that when we finalize the 31.0.0 release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the field
precise_license_detectionfrom the license scoring plugin toidentification_precision, which is the original intended name for the field.