Convert package data dict to PackageData #2971 #2973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jono Yang <jyang@nexb.com>
pombredanne
reviewed
May 20, 2022
src/packagedcode/debian.py
Outdated
| @@ -402,10 +402,11 @@ def assemble(cls, package_data, resource, codebase): | |||
| continue | |||
|
|
|||
| for pkgdt in res.package_data: | |||
| pkgdt = models.PackageData.from_dict(pkgdt) | |||
There was a problem hiding this comment.
I wonder if this could be done directly in package.update where we could accept package_data as a mapping or as an object and convert to object if needed?
There was a problem hiding this comment.
Good point, I've updated Package.update() to convert the package data to a PackageData object if the incoming package data is in a dictionary.
Signed-off-by: Jono Yang <jyang@nexb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue where scancode encountered errors when scanning for system packages from a distroless docker root filesystem. The issue was that the package data on the resource, which is in a dictionary, was being passed into
Package.update()whenPackage.update()was expecting aPackageDataobject instead.