Consider only copyrights in summry #2972 #2974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jono Yang <jyang@nexb.com>
* Update expected test results
* TODO: consider not converting common company names to a canonical form
Signed-off-by: Jono Yang <jyang@nexb.com>
* If no explicit copyright was detected from Package datafiles, then we take the holder detections from those files instead Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang
force-pushed
the
2972-summary-consider-copyrights
branch
from
e24d6d3
to
3a8e01e
Compare
Signed-off-by: Jono Yang <jyang@nexb.com>
* Update expected test results Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang
force-pushed
the
2972-summary-consider-copyrights
branch
from
e123b30
to
431cfa6
Compare
Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang
force-pushed
the
2972-summary-consider-copyrights
branch
from
431cfa6
to
91a2094
Compare
pombredanne
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the logic that uses author or maintainers as the declared holder if no explicit copyright was detected from package data. However, I am still not sure about how I feel the
tallyfunctions normalize copyright holders to a different value for the sake of grouping as it can be misleading.Reference: #2972