Reimplement get installed packages #2988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonoYang
force-pushed
the
reimplement-get-installed-packages
branch
2 times, most recently
from
5117a37
to
0676fe5
Compare
Signed-off-by: Jono Yang <jyang@nexb.com>
* Update function signatures for get_installed_packages Signed-off-by: Jono Yang <jyang@nexb.com>
* Modify run_scan to return a codebase
* Create new PackageWithResources class
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
* Override to_dict on PackageWithResources
* Update expected test results
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
JonoYang
force-pushed
the
reimplement-get-installed-packages
branch
from
6cf681d
to
f2fcc3b
Compare
|
tests/packagedcode/test_pypi.py::TestPyPiEndtoEnd::test_package_scan_pypi_end_to_end is failing only in the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the function
get_installed_packagestopackagedcode/plugin_packages.pyas a replacement toget_installed_packagesfrompackagedcode/alpine.py,packagedcode/debian.py, andpackagedcode/rpm.py