Improve npm package processing #2997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the package_uid is None we should not assign this as the package of a resource when doing package assemble() processing. We should insyead skip this. This was discovered in npm, but could apply to other package types. Reported-by: Thomas Druez <tdruez@nexb.com> Reference: nexB/scancode.io#448 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Reference: #2996 Reference: nexB/scancode.io#448 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
|
@tdruez this is fairly non-controversial so I am merging this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has fixes for two npm issues: empty, dummy URLs and "for_packages" reported as a null/None mistakenly.
Tasks
Run tests locally to check for errors.
Signed-off-by: Philippe Ombredanne pombredanne@nexb.com