Do not fail without packages in cyclonedx #2987 #3005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonoYang
approved these changes
Jun 22, 2022
There was a problem hiding this comment.
@AyanSinhaMahapatra Looks good! You'll also need to update the expected test result for the test test_CycloneDxMetadata_from_headers
Avoids crashing when generating a cyclonedx sbom from scancode-toolkit when there aren't any package options specified. Also show a warning message in the CLI and add a warning in the BOM metadata. Reference: #2987 Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra
force-pushed
the
2987-cyclonedx
branch
from
dc50f07
to
c1599f2
Compare
|
@JonoYang made the changes, tests all green now. |
|
@AyanSinhaMahapatra Great, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids crashing when generating a cyclonedx sbom from scancode-toolkit
when there aren't any package options specified. Also show a warning
message in the CLI and add a warning in the BOM metadata.
Reference: #2987
Signed-off-by: Ayan Sinha Mahapatra ayansmahapatra@gmail.com
Tasks
Run tests locally to check for errors.