Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yield Packages before other yieldables #3028 #3031

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

pombredanne
Copy link
Member

  • Update assembly method of cocoapods and pypi package
    handlers to yield Package objects before Resources and Dependencies

Referenced-by: #3028
Signed-off-by: Jono Yang jyang@nexb.com

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • Tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 馃搧

    * Update assembly method of cocoapods and pypi package handlers to yield Package objects before Resources and Dependencies

Signed-off-by: Jono Yang <jyang@nexb.com>
Copy link
Member Author

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM... I will merge shortly.
@TG1999 FYI, the PyPI changes will need backporting to the python-inspector

Copy link
Member Author

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! merging

@pombredanne pombredanne merged commit 55c8fac into develop Jul 28, 2022
@pombredanne pombredanne deleted the 3028-yield-packages-first branch July 28, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants