Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve release scripts #3040 #3046

Merged
merged 13 commits into from
Aug 14, 2022
Merged

Improve release scripts #3040 #3046

merged 13 commits into from
Aug 14, 2022

Conversation

pombredanne
Copy link
Member

@pombredanne pombredanne commented Aug 10, 2022

Some release archves where missing critical wheels.
The solution is to:

  • ensure that we have effectively missing wheels published and made
    available from our PyPI repo when building a release

  • Improve the fetch_thirdparty script to fall back on fetching a
    source distribution when no wheel is found. Fail loudly if neither a
    wheel not an sdist is found. Also accept special cases of packages with
    no wheels and packages with no sources.

  • Ensure that some source-only packages are always included as sources

  • Add release smoke tests and run then for each wheel, sdist and app
    archive on supported OS and Python versions combinations

  • Move Linux-only requirements to theur own requirement file.

  • Enable Linux-only package inspectors on Linux only.

  • Run base tests on macos 12

Signed-off-by: Philippe Ombredanne pombredanne@nexb.com

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • Tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 馃搧

Some release archves where missing critical wheels.
The solution is to:

* ensure that we have effectively missing wheels published and made
available from our PyPI repo when building a release

* Improve the fetch_thirdparty script to fall back on fetching a
source distribution when no wheel is found. Fail loudly if neither a
wheel not an sdist is found. Also accept special cases of packages with
no wheels and packages with no sources.

* Ensure that some source-only packages are always included as sources

* Add release smoke tests and run then for each wheel, sdist and app
  archive on supported OS and Python versions combinations

* Move Linux-only requirements to theur own requirement file.

* Enable Linux-only package inspectors on Linux only.

* Run base tests on macos 12

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This should make the CI runtime acceptable

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Only needed on 3.7

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Drop libfwsi-python

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
We do not install any "extras" by default there. And extras cannot
be empty.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Use python3 as the base Python used on Posix

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Also test wheels on fewer combos

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Copy link
Member Author

All release build and install tests are now passing for Windows, Linux and macOS!... This will be merged shortly.

@pombredanne pombredanne merged commit 6cf0585 into develop Aug 14, 2022
@pombredanne pombredanne deleted the macos-12-test branch August 14, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant