Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed restructuredtext bulleted list to use * #3116

Merged
merged 2 commits into from
Sep 27, 2022

Conversation

bwjohnson-ss
Copy link
Contributor

@bwjohnson-ss bwjohnson-ss commented Sep 24, 2022

It wasn't rendering right here: https://scancode-toolkit.readthedocs.io/en/stable/explanations/overview.html#how-does-scancode-detect-licenses

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • Tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 馃搧

@AyanSinhaMahapatra
Copy link
Member

Thanks a lot @bwjohnson-ss, could you paste your signoff here/rebase with signoff?

This is ready to merge otherwise.

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pombredanne pombredanne merged commit 69fe74b into nexB:develop Sep 27, 2022
@pombredanne
Copy link
Member

@AyanSinhaMahapatra oops! I forgot the signoff... now this is a rather minimal change. @bwjohnson-ss still it would be good if you can paste this here for the posterity!

@bwjohnson-ss
Copy link
Contributor Author

Paste Like this?

Signed-off-by: Ben Johnson bwj.johnson@gmail.com

@AyanSinhaMahapatra
Copy link
Member

Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants