Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect wurfl commercial license #3163

Merged
merged 4 commits into from
Dec 12, 2022
Merged

Detect wurfl commercial license #3163

merged 4 commits into from
Dec 12, 2022

Conversation

pombredanne
Copy link
Member

@pombredanne pombredanne commented Nov 29, 2022

This PR add rules to properly detect a wurlf commercial license
in haproxy for #3162

See also upstream issue reported at haproxy/haproxy#1948

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • Tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 馃搧

@pombredanne
Copy link
Member Author

@vargenau FYI

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Do not try funky binary writing

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Reference: #3162
Reference: haproxy/haproxy#1948
Reported-by: Marc-Etienne Vargenau <marc-etienne.vargenau@nokia.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne pombredanne merged commit e72110b into develop Dec 12, 2022
@pombredanne pombredanne deleted the 3162-wurfl-license branch December 12, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant