Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unhashable type error in cyclonedx #3016 #3189

Merged
merged 2 commits into from
Jan 6, 2023
Merged

Fix unhashable type error in cyclonedx #3016 #3189

merged 2 commits into from
Jan 6, 2023

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Jan 6, 2023 •
edited

Signed-off-by: Ayan Sinha Mahapatra ayansmahapatra@gmail.com

Fixes #3016

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • Tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 馃搧

@AyanSinhaMahapatra
Reproduce unhashable type error in cyclonedx #3016
553e624 
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra AyanSinhaMahapatra force-pushed the 3016-fix-cyclonedx branch 2 times, most recently from 0a24921 to e0a1380 Compare January 6, 2023 16:48
@AyanSinhaMahapatra
Copy link
Member Author

Reproduced unhashable type failure: https://dev.azure.com/nexB/scancode-toolkit/_build/results?buildId=9474&view=logs&j=1412dbfa-421a-5a40-8ddf-7073fc46aa19&t=13c90161-2109-5957-f563-a96fefc7d869&l=6410

@AyanSinhaMahapatra AyanSinhaMahapatra changed the title Fix unhashable type error in cyclonedx #3016 [WIP] Fix unhashable type error in cyclonedx #3016 Jan 6, 2023
@AyanSinhaMahapatra AyanSinhaMahapatra modified the milestones: v32.1, v32.0 Jan 6, 2023
@AyanSinhaMahapatra
Fix cyclonedx unhashable type bug #3016
6739606 
* list of unhashable objects were being used to create a set,
  thus the error. Now we are using hashable identifier strings
  to create the set instead for all objects.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
pombredanne
pombredanne approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! I am approving as is but please add an issue for follow up work to:

  • support newer/newest versions of the spec
  • add support for dependencies and more details

@AyanSinhaMahapatra AyanSinhaMahapatra mentioned this pull request Jan 6, 2023
Open
@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 0aa964e into develop Jan 6, 2023
@pombredanne pombredanne deleted the 3016-fix-cyclonedx branch January 6, 2023 20:41
@AyanSinhaMahapatra AyanSinhaMahapatra mentioned this pull request Mar 15, 2023
Open
@AyanSinhaMahapatra AyanSinhaMahapatra mentioned this pull request May 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v32.0
Development

Successfully merging this pull request may close these issues.

Exception when creating cyclonedx output
2 participants
@AyanSinhaMahapatra @pombredanne