Fix choking license detection post-processing #3245 #3247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pombredanne
reviewed
Feb 13, 2023
AyanSinhaMahapatra
force-pushed
the
3245-lic-detection-stuck
branch
from
f21c02d
to
6814e24
Compare
We were iterating over license detections, which was taking forever to complete and this approach uses a dict/hashmap instead which fixes the issue here. Reference: #3245 Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com> Reported-by: Philippe Ombredanne <pombredanne@nexb.com> Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra
force-pushed
the
3245-lic-detection-stuck
branch
from
6814e24
to
f2a08de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were iterating over license detections, which was taking forever to complete and this approach uses a dict/hashmap instead which fixes the issue here.
Reference: #3245
Signed-off-by: Ayan Sinha Mahapatra ayansmahapatra@gmail.com
Reported-by: Philippe Ombredanne pombredanne@nexb.com
Fixes #3245
Tasks
Run tests locally to check for errors.