Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence pyicu warning #3280

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Silence pyicu warning #3280

merged 2 commits into from
Apr 3, 2023

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Feb 28, 2023

Fixes #2990

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • Tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 馃搧

Signed-off-by: Ritik Ranjan <rritik772@outlook.com>
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Copy link
Contributor

@JonoYang JonoYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AyanSinhaMahapatra
Copy link
Member Author

Thanks @JonoYang @pombredanne , merging!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 50206ef into develop Apr 3, 2023
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the silence-pyicu-warning branch April 3, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Silence noisy warnings for pyicu
4 participants