Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update licenses and rules #3513

Merged
merged 13 commits into from
Sep 21, 2023
Merged

Update licenses and rules #3513

merged 13 commits into from
Sep 21, 2023

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Sep 18, 2023 •
edited
Loading

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Looked for possible updates in documentation and added updates if applicable
  • Updated CHANGELOG.rst

@AyanSinhaMahapatra
Fix oauthlib license detections
8893f09 
Reference: #3512
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Add false positive rules and misc
4a344b9 
Reference: #3509
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Add new and updated licenses
100b9e8 
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Add pypi license detection updates
2c1d41b 
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Fix test failures
29b7ba9 
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Update license text for lbnl-bsd
3ac8e96 
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Add rules and license detection updates
570c43f 
* Add new license rules from jacoco
* Add updates to the license clue heuristics

Reference: #3515
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Add updated test expectations
0dfb0ca 
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Add free-surfer license
87b0b8e 
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Remove unnecessary code
2fcb719 
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Add false positve license rules
d8b0dbe 
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Add new and updated license detection rules
9c90afe 
* New rule additions
* Updating rules as intros and clues

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
pombredanne
pombredanne approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
See some small nits for your consideration and please merge.

src/licensedcode/data/rules/epl-2.0_70.RULE Outdated Show resolved Hide resolved
src/licensedcode/data/rules/epl-2.0_70.RULE Outdated Show resolved Hide resolved
src/licensedcode/data/rules/lbnl-bsd_13.RULE Outdated Show resolved Hide resolved
src/licensedcode/data/rules/python_98.RULE Show resolved Hide resolved
@AyanSinhaMahapatra
Add updates for review comments
4678e22 
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra AyanSinhaMahapatra mentioned this pull request Sep 21, 2023
Closed
@AyanSinhaMahapatra
Copy link
Member Author

Addressed comments and added updates. All green except the usual suspects the heisenbugs. Merging!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 9e4d706 into develop Sep 21, 2023
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AyanSinhaMahapatra @pombredanne