Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cargo package detection support #3783

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented May 20, 2024

Improvements and bugfixes:

  • Fix for parser crashing on cargo workspaces
  • Fix a bug in dependency parsing (we were not returning any dependencies)
  • Also support getting dependency versions from workspace
  • Support more attributes from cargo
  • Better handle workspace data thorugh extra_data ({workspace = true} would not be seen anymore even on parser failing)
  • clean up workspace data from extra data on resolution

Reference: #3769

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • Tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 馃搧
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

Reference: #3769
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! great. Just need a changelog

@AyanSinhaMahapatra AyanSinhaMahapatra changed the title Improve cargo workspace support Improve cargo package detection support Jun 10, 2024
@AyanSinhaMahapatra AyanSinhaMahapatra linked an issue Jun 10, 2024 that may be closed by this pull request
@AyanSinhaMahapatra
Copy link
Member Author

Thanks @pombredanne , added CHANGELOG, now merging!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 8f5daf7 into develop Jun 10, 2024
6 of 34 checks passed
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the fix-cargo-workspaces branch June 10, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected output for field vcs_url in cargo workkspaces
2 participants