Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Empty directory being shown with file icon #604

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Fixed Empty directory being shown with file icon #604

merged 1 commit into from
Oct 16, 2023

Conversation

OmkarPh
Copy link
Collaborator

@OmkarPh OmkarPh commented Oct 2, 2023

Fixes #542

@OmkarPh
Fixed #542 file icon being shown for empty directories
a9c97e8 
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@OmkarPh OmkarPh linked an issue Oct 2, 2023 that may be closed by this pull request
Empty directory displays file icon #542
Closed
@OmkarPh OmkarPh marked this pull request as ready for review October 2, 2023 13:04
@OmkarPh OmkarPh changed the base branch from v4.0-react-typescript to feature/unittests October 2, 2023 13:09
@OmkarPh OmkarPh requested a review from mjherzog October 2, 2023 13:10
@AyanSinhaMahapatra AyanSinhaMahapatra mentioned this pull request Oct 16, 2023
Closed
AyanSinhaMahapatra
AyanSinhaMahapatra approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks @OmkarPh
The fix is working perfectly.
empty-dir
Please merge.

@OmkarPh OmkarPh merged commit 241487f into feature/unittests Oct 16, 2023
7 checks passed
@OmkarPh
Copy link
Collaborator Author

OmkarPh commented Oct 16, 2023

Thanks for the review !
Merging

@AyanSinhaMahapatra AyanSinhaMahapatra deleted the fix/emptyDirectoryIcon branch October 25, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyanSinhaMahapatra AyanSinhaMahapatra AyanSinhaMahapatra approved these changes

@mjherzog mjherzog Awaiting requested review from mjherzog

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty directory displays file icon
2 participants
@OmkarPh @AyanSinhaMahapatra